pb-3031: enable the RESOURCE_CLENAUP field to kdmp-config #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new data RESOURCE_CLEANUP which is when set to false then CRs and other resources will not be cleaed up in case of failure. This is to help debug the issue in case of generic backup effectively Signed-off-by: Lalatendu Das <[email protected]>
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #1145 +/- ##
==========================================
- Coverage 68.47% 68.40% -0.07%
==========================================
Files 42 42
Lines 4628 4628
==========================================
- Hits 3169 3166 -3
- Misses 1145 1147 +2
- Partials 314 315 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new data RESOURCE_CLEANUP which is when set to false then
CRs and other resources will not be cleaed up in case of failure.
This is to help debug the issue in case of generic backup effectively
Signed-off-by: Lalatendu Das [email protected]
What type of PR is this?
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?: